Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11367 )
Change subject: Improve logging of maintenance ops ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11367/2/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/11367/2/src/kudu/tablet/delta_compaction.cc@296 PS2, Line 296: // Throwaway struct to combine stats from multiple delta stores. : struct MergedDeltaStats { Do you expect to use this more extensively? Why not just a `string DeltaStoreStatsToString(vector<DeltaStore>)`? -- To view, visit http://gerrit.cloudera.org:8080/11367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43883001c5a1c72ff1ca0c1bc84d24a8533e3891 Gerrit-Change-Number: 11367 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 31 Aug 2018 05:15:41 +0000 Gerrit-HasComments: Yes
