Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11374 )
Change subject: build: retry failed tests by default ...................................................................... Patch Set 1: (5 comments) It should be noted that this change will make it easier to merge a new test that is flaky from day one. In the past I opposed making such a policy change, but I've since come around: minimizing precommit friction is a more important goal, and the flaky test dashboard will (eventually) tell us about a new test's flakiness. http://gerrit.cloudera.org:8080/#/c/11374/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11374/1//COMMIT_MSG@13 PS1, Line 13: retry tests all tests Nit: retry all failed tests http://gerrit.cloudera.org:8080/#/c/11374/1/build-support/dist_test.py File build-support/dist_test.py: http://gerrit.cloudera.org:8080/#/c/11374/1/build-support/dist_test.py@61 PS1, Line 61: # Whether to retry all failed C++ tests, rather than just known flaky tests. : # Since Java flaky tests are not reported by the test server, Java tests are : # always retried, regardless of this value. : RETRY_ALL_TESTS = int(os.environ.get('KUDU_RETRY_ALL_FAILED_TESTS', 0)) This no longer exists, right? I mean, we no longer read this env var in run-test.sh, so I assume we shouldn't here either. http://gerrit.cloudera.org:8080/#/c/11374/1/build-support/dist_test.py@376 PS1, Line 376: flaky_test_set=set()): Doesn't seem like we're using this anymore either. http://gerrit.cloudera.org:8080/#/c/11374/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/11374/1/build-support/jenkins/build-and-test.sh@40 PS1, Line 40: # KUDU_FLAKY_TEST_ATTEMPTS Default: 1 Shouldn't we default this to 3 to honor the intent of this change? http://gerrit.cloudera.org:8080/#/c/11374/1/build-support/run-test.sh File build-support/run-test.sh: http://gerrit.cloudera.org:8080/#/c/11374/1/build-support/run-test.sh@27 PS1, Line 27: This can be used in the gerrit workflow : # to prevent annoying false-negatives. This script feels a little too far removed from gerrit to mention it. -- To view, visit http://gerrit.cloudera.org:8080/11374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fc069527d6f2553a4e04e14c821090f826cbc0a Gerrit-Change-Number: 11374 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 31 Aug 2018 20:00:34 +0000 Gerrit-HasComments: Yes
