Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 )
Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java File java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java: http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducer.java@364 PS3, Line 364: default: Should a runtime exception be thrown if no policy is defined? http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java File java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java: http://gerrit.cloudera.org:8080/#/c/11391/3/java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/RegexpKuduOperationsProducerParseErrorTest.java@50 PS3, Line 50: public ExpectedException thrown= ExpectedException.none(); nit: space before -= -- To view, visit http://gerrit.cloudera.org:8080/11391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b352b27583ae9eee6cdbe28a768362bea36e00f Gerrit-Change-Number: 11391 Gerrit-PatchSet: 3 Gerrit-Owner: Ferenc Szabo <fsz...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 10 Sep 2018 17:35:58 +0000 Gerrit-HasComments: Yes
