Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11401 )
Change subject: [gutil] add LookupOrEmplace() ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11401/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11401/2//COMMIT_MSG@10 PS2, Line 10: new > nit: redundant with subsequent 'new'. Done http://gerrit.cloudera.org:8080/#/c/11401/2/src/kudu/gutil/map-util.h File src/kudu/gutil/map-util.h: http://gerrit.cloudera.org:8080/#/c/11401/2/src/kudu/gutil/map-util.h@499 PS2, Line 499: achive > achieve Done http://gerrit.cloudera.org:8080/#/c/11401/2/src/kudu/gutil/map-util.h@501 PS2, Line 501: ... > What's this ellipsis for? That was just copy-paste from cppreference. I think this ellipsis is from the signature of the emplace functions. I'll remove that. http://gerrit.cloudera.org:8080/#/c/11401/2/src/kudu/gutil/map-util.h@502 PS2, Line 502: key > nit: same key Done -- To view, visit http://gerrit.cloudera.org:8080/11401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a177f410c1d4ed33e6f44cb7d6c33d6141f84fc Gerrit-Change-Number: 11401 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 10 Sep 2018 20:12:18 +0000 Gerrit-HasComments: Yes
