Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11399 )
Change subject: build: add option to ignore test failures ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11399/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/11399/1/build-support/jenkins/build-and-test.sh@618 PS1, Line 618: if [ $TESTS_FAILED != 0 -o $EXIT_STATUS != 0 ]; then > You can combine this: Done http://gerrit.cloudera.org:8080/#/c/11399/1/build-support/jenkins/build-and-test.sh@658 PS1, Line 658: # If any of the tests failed and we are honoring test failures, set the exit > And combine this too. Done http://gerrit.cloudera.org:8080/#/c/11399/1/build-support/jenkins/build-and-test.sh@659 PS1, Line 659: # status to 1. Note that it may have already been set to 1 above. > Should we avoid overwriting if EXIT_STATUS is non-zero? Is that even possib Maybe it's an implementation detail, but EXIT_STATUS only ever gets sets to 1, and is 0 otherwise. I'll add a comment to that effect. -- To view, visit http://gerrit.cloudera.org:8080/11399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27ecacd499423755dbf742bb70db6a7f1e5c9db7 Gerrit-Change-Number: 11399 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 10 Sep 2018 21:54:05 +0000 Gerrit-HasComments: Yes
