Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 )
Change subject: move KUDU_NO_EXPORT attribute on methods ...................................................................... Patch Set 2: Interestingly this issue only cropped up with modify_external_catalogs, I believe because it's the only use of the annotation with a pointer return type. I moved all annotations to maintain consistency and make it more likely that a copy/paste of the annotation in the future will not be broken. -- To view, visit http://gerrit.cloudera.org:8080/11415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57 Gerrit-Change-Number: 11415 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 10 Sep 2018 23:54:00 +0000 Gerrit-HasComments: No
