Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 )
Change subject: HMS integration: provide Java API to override owner during table create ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11413/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11413/3//COMMIT_MSG@7 PS3, Line 7: Java > A C++ client API as well? This commit only includes an unstable Java API. http://gerrit.cloudera.org:8080/#/c/11413/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java: http://gerrit.cloudera.org:8080/#/c/11413/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@228 PS3, Line 228: setOwner > Do we want to validate if this is only be called by a service users? e.g Im We don't have the concept of a service user in Kudu, so it's not straightforward to do that. Without fine grained authorizations I think it's fine to have this be usable by any user who can create a table, however we'll need to revisit this once Kudu supports finer grained access control. http://gerrit.cloudera.org:8080/#/c/11413/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java: http://gerrit.cloudera.org:8080/#/c/11413/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@27 PS3, Line 27: provide an API to look up the table owner > +1 it's seams unusual to provide a way to set but not check. It would also I'm against providing that API since I don't know of a use-case for it. -- To view, visit http://gerrit.cloudera.org:8080/11413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21069d81a4b54e55c399933b69789bf83bd58de0 Gerrit-Change-Number: 11413 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 11 Sep 2018 21:24:12 +0000 Gerrit-HasComments: Yes
