Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 )
Change subject: [location_awareness] replica selection honors placement policy ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/11207/11/src/kudu/master/placement_policy.cc File src/kudu/master/placement_policy.cc: http://gerrit.cloudera.org:8080/#/c/11207/11/src/kudu/master/placement_policy.cc@134 PS11, Line 134: located > Nit: "are located" Done http://gerrit.cloudera.org:8080/#/c/11207/11/src/kudu/master/placement_policy.cc@145 PS11, Line 145: existing_set.emplace(std::move(ts)); > EmplaceOrDie? Or do you expect duplicates? Done http://gerrit.cloudera.org:8080/#/c/11207/11/src/kudu/master/placement_policy.cc@178 PS11, Line 178: // Get the load of the location: a location with N tablet servers and R replicas : // has load R/N. : // : // Parameters: : // 'location' The location in question. : // 'locations_info' Information on tablet replicas slated for placement, : // but not created yet. That's the placement information : // on to-be-replicas in the context of optimizing tablet : // replica distribution in the cluster. > Move this to the header file. Done -- To view, visit http://gerrit.cloudera.org:8080/11207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4169098abf17d5591d4c1675561afc15b5477fcd Gerrit-Change-Number: 11207 Gerrit-PatchSet: 11 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 12 Sep 2018 22:38:09 +0000 Gerrit-HasComments: Yes
