Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11436 )
Change subject: KUDU-2095: [java] Add scanner keepAlive API to the Java client ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11436/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/11436/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@85 PS1, Line 85: if ("testKeepAlive".equals(testName.getMethodName()) || : "testScannerExpiration".equals(testName.getMethodName()) : ) > I think as long as the result is a broken test we should be okay in the mea In this case it does look like the tests would fail, but in the general case, tests might just become more flaky, so I think it's important for us to get this right. Handling it in a follow-up is fine. http://gerrit.cloudera.org:8080/#/c/11436/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/11436/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@66 PS2, Line 66: import org.junit.rules.TestName; Why did this move? -- To view, visit http://gerrit.cloudera.org:8080/11436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic802f556c8860cdd43ef5f794c8f3658259bd0be Gerrit-Change-Number: 11436 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 13 Sep 2018 19:27:17 +0000 Gerrit-HasComments: Yes
