Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11394 )
Change subject: KUDU-686 (part 1/2): decompose guts of DMSIterator into DeltaPreparer ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Changes look good to me http://gerrit.cloudera.org:8080/#/c/11394/2/src/kudu/tablet/delta_store.h File src/kudu/tablet/delta_store.h: http://gerrit.cloudera.org:8080/#/c/11394/2/src/kudu/tablet/delta_store.h@219 PS2, Line 219: // PreparedDeltas implementation suitable for composing inside a DeltaIterator. Mind adding a little more color around what this class does? -- To view, visit http://gerrit.cloudera.org:8080/11394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26c92dfa69b5323e7fbb18d02010ed99cc29c3e5 Gerrit-Change-Number: 11394 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 14 Sep 2018 18:43:31 +0000 Gerrit-HasComments: Yes
