Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11448 )
Change subject: [tests] test scenario for KUDU-2580 ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/11448/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11448/2//COMMIT_MSG@7 PS2, Line 7: tests nit: I would categorize tests with the subsystem they test, so [security] instead of [tests]. I think it's more useful for the log that way. http://gerrit.cloudera.org:8080/#/c/11448/2/src/kudu/integration-tests/authn_token_expire-itest.cc File src/kudu/integration-tests/authn_token_expire-itest.cc: http://gerrit.cloudera.org:8080/#/c/11448/2/src/kudu/integration-tests/authn_token_expire-itest.cc@143 PS2, Line 143: 3 /* num_tablet_servers */ nit: The prevailing way to format this is /*num_tablet_servers=*/3 http://gerrit.cloudera.org:8080/#/c/11448/2/src/kudu/integration-tests/authn_token_expire-itest.cc@144 PS2, Line 144: 1 /* num_masters */ Ditto. http://gerrit.cloudera.org:8080/#/c/11448/2/src/kudu/integration-tests/authn_token_expire-itest.cc@360 PS2, Line 360: 2 /* token_validity_seconds */, : 3 /* num_tablet_servers */, : 1 /* num_masters * Ditto. http://gerrit.cloudera.org:8080/#/c/11448/2/src/kudu/integration-tests/authn_token_expire-itest.cc@425 PS2, Line 425: 2 /* token_validity_seconds */, : 3 /* num_tablet_servers */, : 3 /* num_masters */ Ditto. -- To view, visit http://gerrit.cloudera.org:8080/11448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58218deef24cca7c524bc61700cd400cdaabd050 Gerrit-Change-Number: 11448 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 18 Sep 2018 18:20:15 +0000 Gerrit-HasComments: Yes
