Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11460 )
Change subject: [hms] relax the notification format restriction ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11460/1/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/11460/1/src/kudu/master/hms_notification_log_listener.cc@184 PS1, Line 184: if (!event.messageFormat.empty() && event.messageFormat != "json-0.2") { Could you add a comment explaining what `messageFormat.empty()` means in terms of parsing a message? Also, could you add some small tests that expect failures when it's a non-empty non-"json-0.2" string? -- To view, visit http://gerrit.cloudera.org:8080/11460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09d0e36cebe2074d975504d6bbc5677107e33fe3 Gerrit-Change-Number: 11460 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 18 Sep 2018 18:48:40 +0000 Gerrit-HasComments: Yes
