Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11467 )

Change subject: [hms] enable special characters support in mini HMS
......................................................................


Patch Set 1:

(1 comment)

> (1 comment)
 >
 > The catalog manager doesn't try to enforce Hive naming conventions,
 > right? It just passes names through to the HMS for validation?

Actually, catalog manager calls hms catalog for create/delete/alter HMS tables, 
and hms catalog does validate the naming. Then HMS will do another round of 
validation.

http://gerrit.cloudera.org:8080/#/c/11467/1/src/kudu/hms/mini_hms.cc
File src/kudu/hms/mini_hms.cc:

http://gerrit.cloudera.org:8080/#/c/11467/1/src/kudu/hms/mini_hms.cc@209
PS1, Line 209:   // - datanucleus.schema.autoCreateAll
> Could you update this comment to reflect the additional non-default paramet
Done



--
To view, visit http://gerrit.cloudera.org:8080/11467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ae5387c6c39a3d0c622316e5cda3236660806a4
Gerrit-Change-Number: 11467
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 19 Sep 2018 20:52:23 +0000
Gerrit-HasComments: Yes

Reply via email to