Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11474 )
Change subject: [test] Clean up MiniKuduCluster and BaseKuduTest ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11474/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/11474/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@178 PS1, Line 178: throw new RuntimeException(resp.getError().getMessage()); > Yeah, that is what I am saying. It will take some more changes to make that I will undo the change in this patch and then make the change in the patch that needs it at a later point. http://gerrit.cloudera.org:8080/#/c/11474/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@479 PS1, Line 479: /** : * Converts HostPortPB to an unresolved InetSocketAddress. : * : * @param pb the host and port to convert : * @return an unresolved InetSocketAddress : */ : private static InetSocketAddress addressFromPB(HostPortPB pb) { : return InetSocketAddress.createUnresolved(pb.getHost(), pb.getPort()); : } > This isn't KUDU-2186. In fact that issue is fixed by removing HostAndPort f I will reuse ProtobufHelper in this patch and then make the change in the patch that needs it at a later point. -- To view, visit http://gerrit.cloudera.org:8080/11474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a55c41f48f31c4a12b41508dbb343c4419e65b1 Gerrit-Change-Number: 11474 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 20 Sep 2018 04:04:19 +0000 Gerrit-HasComments: Yes
