Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11142 )
Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops ...................................................................... Patch Set 8: Code-Review+1 (6 comments) looks ready to go, just a few more wording nits http://gerrit.cloudera.org:8080/#/c/11142/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11142/8//COMMIT_MSG@16 PS8, Line 16: The same : cannot necessarily be said for timestamps of no-ops and change configs. Because no-op and change config operations are not serialized through the prepare thread, they don't necessarily provide the same timestamp monotonicity guarantees. http://gerrit.cloudera.org:8080/#/c/11142/8//COMMIT_MSG@19 PS8, Line 19: This is a conservative conclusion about assigned timestamps, and this : patch hinges on the fact However in the case of no-ops replicated to assert leadership, we get the same timestamp monotonicity guarantee due to a different mechanism. This patch takes advantage of the fact that... http://gerrit.cloudera.org:8080/#/c/11142/8//COMMIT_MSG@31 PS8, Line 31: within the same term for a given term http://gerrit.cloudera.org:8080/#/c/11142/8//COMMIT_MSG@34 PS8, Line 34: safetime MVCC safe time http://gerrit.cloudera.org:8080/#/c/11142/8//COMMIT_MSG@37 PS8, Line 37: prevent always prevent http://gerrit.cloudera.org:8080/#/c/11142/8//COMMIT_MSG@37 PS8, Line 37: reduces the window : during which incorrect results can be returned dramatically reduces the likelihood of it occurring -- To view, visit http://gerrit.cloudera.org:8080/11142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26deff32da8c990cb8a2ba220bb81858ddd6d73f Gerrit-Change-Number: 11142 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 20 Sep 2018 21:35:19 +0000 Gerrit-HasComments: Yes
