Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11493 )
Change subject: Add thrift module for common thrift utilities ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11493/1/src/kudu/hms/hms_client.h File src/kudu/hms/hms_client.h: http://gerrit.cloudera.org:8080/#/c/11493/1/src/kudu/hms/hms_client.h@97 PS1, Line 97: // Starts the HMS client. > warning: function 'kudu::hms::HmsClient::HmsClient' has a definition with d Done http://gerrit.cloudera.org:8080/#/c/11493/1/src/kudu/hms/hms_client.cc File src/kudu/hms/hms_client.cc: http://gerrit.cloudera.org:8080/#/c/11493/1/src/kudu/hms/hms_client.cc@51 PS1, Line 51: using kudu::thrift::SaslException; > warning: using decl 'SaslClientTransport' is unused [misc-unused-using-decl Done http://gerrit.cloudera.org:8080/#/c/11493/1/src/kudu/hms/hms_client.cc@53 PS1, Line 53: using std::string; > warning: using decl 'make_shared' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/11493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f6f843f42b37cb1170df03da01fc0790fe94acb Gerrit-Change-Number: 11493 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 21 Sep 2018 23:00:57 +0000 Gerrit-HasComments: Yes
