Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 )
Change subject: [tools] ksck checksums: Factor out of main ksck code ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11488/3/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/11488/3/src/kudu/tools/ksck.cc@638 PS3, Line 638: IsNonJSONFormat() ? out_ : nullptr); > This function prints progress messages like Thanks for the explanation. I agree, keeping the flag declarations encapsulated like this and gating the output as you have makes sense. Could you add a comment explaining that we don't want to ruin the JSON output with progress updates? http://gerrit.cloudera.org:8080/#/c/11488/3/src/kudu/tools/ksck_checksum.h File src/kudu/tools/ksck_checksum.h: http://gerrit.cloudera.org:8080/#/c/11488/3/src/kudu/tools/ksck_checksum.h@47 PS3, Line 47: et to use this special timest > I rephrased to be more similar to the description of the flag that relates Gotcha. It is much clearer now. Also reading back the original, it makes sense too. -- To view, visit http://gerrit.cloudera.org:8080/11488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bb1f51af22ab0c6c20b9426dbb62ea48413ed5b Gerrit-Change-Number: 11488 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Sun, 23 Sep 2018 17:53:31 +0000 Gerrit-HasComments: Yes
