David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11495 )
Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally ...................................................................... hybrid_clock: restore SleepFor in WaitUntilAfterLocally This seems to have gone missing from commit f2d96437c. The end result is a busy loop, which was probably unintentional. I also removed the loop, which seemed unnecessary with the SleepFor. To test, I wrote a small program that scanned a table at Now() + 10s, after setting --scanner_max_wait_ms to 10000 (default is 1000). Although the wall clock time was the same, the cycle count was far higher per perf stat. Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e Reviewed-on: http://gerrit.cloudera.org:8080/11495 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/clock/hybrid_clock.cc 1 file changed, 16 insertions(+), 16 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e Gerrit-Change-Number: 11495 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins
