Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11503 )
Change subject: Add Hive Metastore service principal configuration ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11503/1/src/kudu/thrift/client.h File src/kudu/thrift/client.h: http://gerrit.cloudera.org:8080/#/c/11503/1/src/kudu/thrift/client.h@56 PS1, Line 56: // The registered name of the service (Kerberos principal). Can you doc what it means to leave this empty (i.e. the default value)? I presume it must be set on a Kerberized cluster, right? If that's true, perhaps CreateClientProtocol should DCHECK if this is an empty string? -- To view, visit http://gerrit.cloudera.org:8080/11503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c5c56423a62cba0b696f97d866077b35845ce26 Gerrit-Change-Number: 11503 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 25 Sep 2018 00:05:21 +0000 Gerrit-HasComments: Yes
