Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11524 )
Change subject: KUDU-2541: Fill out basic sentry client API ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/11524/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11524/1//COMMIT_MSG@9 PS1, Line 9: This commit contains more plumbin for the upcoming Sentry integration plumbing. Or plumbin' http://gerrit.cloudera.org:8080/#/c/11524/1//COMMIT_MSG@12 PS1, Line 12: Thrifts Thrift's http://gerrit.cloudera.org:8080/#/c/11524/1/src/kudu/sentry/mini_sentry.cc File src/kudu/sentry/mini_sentry.cc: http://gerrit.cloudera.org:8080/#/c/11524/1/src/kudu/sentry/mini_sentry.cc@142 PS1, Line 142: Hadoops Hadoop's http://gerrit.cloudera.org:8080/#/c/11524/1/src/kudu/sentry/mini_sentry.cc@147 PS1, Line 147: has have http://gerrit.cloudera.org:8080/#/c/11524/1/src/kudu/sentry/mini_sentry.cc@199 PS1, Line 199: static const string kUsers = R"( Maybe a short comment documenting the effect these values have? http://gerrit.cloudera.org:8080/#/c/11524/2/src/kudu/sentry/sentry_client-test.cc File src/kudu/sentry/sentry_client-test.cc: http://gerrit.cloudera.org:8080/#/c/11524/2/src/kudu/sentry/sentry_client-test.cc@53 PS2, Line 53: TEST_F(SentryClientTest, TestCreateDropRole) { Other simple tests for error conversion: 1. Create a duplicate role. AlreadyPresent. 2. Drop a non-existent role. NotFound. http://gerrit.cloudera.org:8080/#/c/11524/2/src/kudu/sentry/sentry_client-test.cc@61 PS2, Line 61: ::sentry::TCreateSentryRoleRequest req; How do you feel about building simple Kudu abstractions for the request/response classes? To avoid having ::sentry stuff leak out into the rest of Kudu? Looks like we didn't do that for HMS integration though. http://gerrit.cloudera.org:8080/#/c/11524/1/src/kudu/sentry/sentry_client.h File src/kudu/sentry/sentry_client.h: http://gerrit.cloudera.org:8080/#/c/11524/1/src/kudu/sentry/sentry_client.h@60 PS1, Line 60: proided provided -- To view, visit http://gerrit.cloudera.org:8080/11524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1004a11506ed109d1f23389ca73d95a34c32c194 Gerrit-Change-Number: 11524 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 26 Sep 2018 20:36:52 +0000 Gerrit-HasComments: Yes
