Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11347 )
Change subject: KUDU-428: add Sentry to thirdparty, mini-sentry ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11347/5/src/kudu/sentry/mini_sentry.cc File src/kudu/sentry/mini_sentry.cc: http://gerrit.cloudera.org:8080/#/c/11347/5/src/kudu/sentry/mini_sentry.cc@86 PS5, Line 86: Su > nit: 4 space indent? Done http://gerrit.cloudera.org:8080/#/c/11347/5/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/11347/5/thirdparty/vars.sh@230 PS5, Line 230: apache-sentry-$SENTRY_VERSION-bin > Can we use the same naming rule as for Hive and Hadoop? I'm planning to do the repackaging in a follow up commit, Adar and I talked about it on a different thread in this review. -- To view, visit http://gerrit.cloudera.org:8080/11347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03f39cf9b2c813c0c305d085e1ad3851636326f5 Gerrit-Change-Number: 11347 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 26 Sep 2018 22:25:37 +0000 Gerrit-HasComments: Yes
