Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11529 )
Change subject: [spark] Cleanup hasNext logic ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11529/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java: http://gerrit.cloudera.org:8080/#/c/11529/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java@96 PS1, Line 96: public static RowResultIterator empty() { > Does this need to be annotated so as to be even more constrained than Publi I though about marking it as @InterfaceAudiance.Private, but realistically being able to create an empty RowResultIterator is useful. The fact that I use it in the Spark integration implies that it would be useful to other integrations. Additionally it's not likely we would ever need to "break" this functionality. -- To view, visit http://gerrit.cloudera.org:8080/11529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I340af13a695b3a8489e03018542b8ad7db614758 Gerrit-Change-Number: 11529 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 23:21:16 +0000 Gerrit-HasComments: Yes
