Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11542 )
Change subject: build-and-test.sh: don't rebuild thirdparty ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/11542/1/build-support/jenkins/build-and-test.sh@236 PS1, Line 236: CMAKE=" > If I understand it correctly, when using clang, we will rebuild the thirdpa No, clang is built as part of build-if-necessary.sh on L179. We should only build thirdparty once in build-and-test.sh; this commit ensures that. -- To view, visit http://gerrit.cloudera.org:8080/11542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icba28146b44401499379d7c1f69742578456a448 Gerrit-Change-Number: 11542 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward #314 Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 28 Sep 2018 21:45:54 +0000 Gerrit-HasComments: Yes
