Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11537 )
Change subject: [spark] Add KuduReadOptions to encapsulate the read parameters ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/11537/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: http://gerrit.cloudera.org:8080/#/c/11537/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@78 PS4, Line 78: override def createRelation( > nit: add a comment for the method definition. Done http://gerrit.cloudera.org:8080/#/c/11537/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/11537/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@60 PS4, Line 60: Evolving > Evolving means we cannot break compatibility at major release? The meaning of these tags is defined here: https://github.com/apache/yetus/blob/master/audience-annotations-component/audience-annotations/src/main/java/org/apache/yetus/audience/InterfaceStability.java It means we can break in minor releases but not maintenance releases. Though, I suspect we would do our best not to break in all but major releases if necessary. http://gerrit.cloudera.org:8080/#/c/11537/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala: http://gerrit.cloudera.org:8080/#/c/11537/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala@28 PS4, Line 28: import org.apache.yetus.audience.InterfaceAudience > nit: alphabetical order, can you put yetus package before kudu. Same for th Done http://gerrit.cloudera.org:8080/#/c/11537/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduReadOptions.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduReadOptions.scala: http://gerrit.cloudera.org:8080/#/c/11537/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduReadOptions.scala@30 PS4, Line 30: . > nit: no period in the end for @param. Done -- To view, visit http://gerrit.cloudera.org:8080/11537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaee3d09471cad2cddd816ec77eafaae457faf1c2 Gerrit-Change-Number: 11537 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Mon, 01 Oct 2018 03:12:10 +0000 Gerrit-HasComments: Yes
