Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11508 )
Change subject: [tools] Fix bug in CheckCompleteMove ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11508/1/src/kudu/tools/tool_replica_util.cc File src/kudu/tools/tool_replica_util.cc: http://gerrit.cloudera.org:8080/#/c/11508/1/src/kudu/tools/tool_replica_util.cc@287 PS1, Line 287: nd the : // replica-to-be-removed has stepped down as leader > That's not the only case we need to handle here right? The replica-to-be-r Done http://gerrit.cloudera.org:8080/#/c/11508/1/src/kudu/tools/tool_replica_util.cc@291 PS1, Line 291: to_ts_uuid_is_a_voter > I think additional !from_ts_uuid_in_config condition is missing here. Done -- To view, visit http://gerrit.cloudera.org:8080/11508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I227b8f833e8904dd1ac18fbe17345bea13c96c16 Gerrit-Change-Number: 11508 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 01 Oct 2018 18:34:28 +0000 Gerrit-HasComments: Yes
