Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11554 )
Change subject: [tools] KUDU-2179: Have ksck not use a single snapshot for all tablets ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_checksum.h File src/kudu/tools/ksck_checksum.h: http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_checksum.h@111 PS1, Line 111: // TODO: Implement move constructor for schema. > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_checksum.h@115 PS1, Line 115: schema(std::move(schema)) {} > warning: passing result of std::move() as a const reference argument; no mo I'm planning to rebase on a patch with move construction and assignment implemented for Schema. http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_checksum.h@142 PS1, Line 142: static Status New(KsckChecksumOptions opts, > warning: function 'kudu::tools::ChecksumManager::New' has a definition with Done http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_checksum.h@175 PS1, Line 175: Outcome WaitFor(const MonoDelta& timeout, > warning: function 'kudu::tools::ChecksumManager::WaitFor' has a definition Done http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_checksum.h@189 PS1, Line 189: ChecksumManager(int num_replicas, > warning: function 'kudu::tools::ChecksumManager::ChecksumManager' has a def Done http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_remote.h File src/kudu/tools/ksck_remote.h: http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_remote.h@92 PS1, Line 92: const HostPort host_port, > warning: the const qualified parameter 'host_port' is copied for each invoc Done http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_remote.cc@332 PS1, Line 332: KsckChecksumOptions options, shared_ptr<ChecksumManager> manager, > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_remote.cc@332 PS1, Line 332: KsckChecksumOptions options, shared_ptr<ChecksumManager> manager, > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_remote.cc@337 PS1, Line 337: options_(options), > warning: parameter 'options' is passed by value and only copied once; consi Done http://gerrit.cloudera.org:8080/#/c/11554/1/src/kudu/tools/ksck_remote.cc@338 PS1, Line 338: manager_(manager), > warning: parameter 'manager' is passed by value and only copied once; consi Done -- To view, visit http://gerrit.cloudera.org:8080/11554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff0905c2099e6f56ed1cb651611918acbaf75476 Gerrit-Change-Number: 11554 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 01 Oct 2018 21:55:20 +0000 Gerrit-HasComments: Yes
