Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11547 )
Change subject: [test] Move BaseKuduTest to a Junit Rule ...................................................................... Patch Set 6: (1 comment) > I agree we could make the rule more flexible to not require setting up a > cluster. Given this patch is fairly large and I have a few changes that need > this, do you mind if I do that as a follow on change? Sure. You'll have to remove the RetryRules you've sprinkled in, but that's very little churn so it's fine with me. http://gerrit.cloudera.org:8080/#/c/11547/1/java/kudu-client/src/test/java/org/apache/kudu/test/KuduRule.java File java/kudu-client/src/test/java/org/apache/kudu/test/KuduRule.java: http://gerrit.cloudera.org:8080/#/c/11547/1/java/kudu-client/src/test/java/org/apache/kudu/test/KuduRule.java@43 PS1, Line 43: > I agree, naming this was hard for me and I expected to get some feedback on I don't think so. Add a class-level comment with sample usage and that should be good enough. -- To view, visit http://gerrit.cloudera.org:8080/11547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32c83b47a576377b924ea41dbeaf78ce2b75e4c4 Gerrit-Change-Number: 11547 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Mon, 01 Oct 2018 23:27:17 +0000 Gerrit-HasComments: Yes
