Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11488 )
Change subject: [tools] ksck checksums: Factor out of main ksck code ...................................................................... Patch Set 9: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/11488/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11488/6//COMMIT_MSG@7 PS6, Line 7: of > The "of" is obligatory for the correct meaning, which is that ksck checksum Ah, I see. Now that makes sense to me. Maybe, rephrasing this like below would make it simpler to parse? [tools] factor checksumming out of main ksck code http://gerrit.cloudera.org:8080/#/c/11488/6/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/11488/6/src/kudu/tools/ksck.cc@637 PS6, Line 637: // Don't ruin JSON output by printing progress updates. : auto* out_for_progress_updates = IsNonJSONFormat() ? out_ : nullptr; : bool timed_out = !reporter->WaitFor(options.timeout, out_for_progress_updates); > It's not, it's just relocated from elsewhere in the overall ksck code. Ah, good to know, thanks. Indeed, the internals of the 'out_' shenanigans was not easy to track from this very file and I was too lazy to look inside. http://gerrit.cloudera.org:8080/#/c/11488/8/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/11488/8/src/kudu/tools/ksck_checksum.cc@116 PS8, Line 116: run_time_sec, > I'm going to skip doing this just because this would make me have to resolv SGTM -- To view, visit http://gerrit.cloudera.org:8080/11488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bb1f51af22ab0c6c20b9426dbb62ea48413ed5b Gerrit-Change-Number: 11488 Gerrit-PatchSet: 9 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 02 Oct 2018 06:26:56 +0000 Gerrit-HasComments: Yes
