Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11602 )

Change subject: [mac] Add support for XCode 10
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake
File cmake_modules/CompilerInfo.cmake:

http://gerrit.cloudera.org:8080/#/c/11602/1/cmake_modules/CompilerInfo.cmake@60
PS1, Line 60: # TODO(wdberkeley): 4.1.0svn is also just a guess, for the same 
reasons, and
I think it's more likely to be 5.x or 6.x, but who knows  ¯\_(?)_/¯



--
To view, visit http://gerrit.cloudera.org:8080/11602
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I442a1cd4605858b0800fc7d7686817936efd155e
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 06 Oct 2018 00:12:49 +0000
Gerrit-HasComments: Yes

Reply via email to