Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11612 )
Change subject: Cleanup in rowset SVG layout dumping ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11612/3/src/kudu/tablet/svg_dump.cc File src/kudu/tablet/svg_dump.cc: http://gerrit.cloudera.org:8080/#/c/11612/3/src/kudu/tablet/svg_dump.cc@a73 PS3, Line 73: : nit: why to drop those comments? Are those wrong or outdated? http://gerrit.cloudera.org:8080/#/c/11612/3/src/kudu/tablet/svg_dump.cc@147 PS3, Line 147: *out << R"(<?xml version="1.0" standalone="no"?>)" : << endl : << R"(<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" )" : << R"("http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd";>)" : << endl; nit: maybe, convert this into a multi-line snippet? -- To view, visit http://gerrit.cloudera.org:8080/11612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I521fadf4336f9e11ea611b022cd4d8fcb269dfe2 Gerrit-Change-Number: 11612 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Oct 2018 22:23:13 +0000 Gerrit-HasComments: Yes
