Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11661 )
Change subject: ksck: quell build warning ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11661/1/src/kudu/tools/ksck_checksum.cc File src/kudu/tools/ksck_checksum.cc: http://gerrit.cloudera.org:8080/#/c/11661/1/src/kudu/tools/ksck_checksum.cc@677 PS1, Line 677: return Status::OK(); Our compiler can't figure out that is unreachable? It should be, so maybe LOG_FATAL instead. -- To view, visit http://gerrit.cloudera.org:8080/11661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I696ff790111cc0b371dbb762a3c5167d834136f7 Gerrit-Change-Number: 11661 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 11 Oct 2018 22:00:40 +0000 Gerrit-HasComments: Yes
