Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11665 )
Change subject: [tools] Add a describe table tool ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_common.h File src/kudu/tools/tool_action_common.h: http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_common.h@41 PS1, Line 41: class faststring; > warning: invalid case style for class 'faststring' [readability-identifier- Too bad, that's the name. http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_common.cc@39 PS1, Line 39: #include "kudu/util/async_util.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_common.cc@137 PS1, Line 137: using client::KuduTablet; > warning: using decl 'KuduTablet' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_common.cc@138 PS1, Line 138: using client::KuduTabletServer; > warning: using decl 'KuduTabletServer' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_common.cc@139 PS1, Line 139: using consensus::ConsensusServiceProxy; > warning: using decl 'ConsensusServiceProxy' is unused [misc-unused-using-de It is used, Mr. Tidy Bot. http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_common.cc@889 PS1, Line 889: } else if (!s.ok()) { > warning: do not use 'else' after 'break' [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/11665/1/src/kudu/tools/tool_action_table.cc@167 PS1, Line 167: partition_strs.push_back(std::move(range_partition_str)); > warning: std::move of the const variable 'range_partition_str' has no effec Done -- To view, visit http://gerrit.cloudera.org:8080/11665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib02f2a94cf11d0e60b32cd85be920ca9b99dd977 Gerrit-Change-Number: 11665 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 12 Oct 2018 10:26:32 +0000 Gerrit-HasComments: Yes
