Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11657 )
Change subject: [sentry] Fill out more sentry client API ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11657/1/src/kudu/sentry/sentry_client-test.cc File src/kudu/sentry/sentry_client-test.cc: http://gerrit.cloudera.org:8080/#/c/11657/1/src/kudu/sentry/sentry_client-test.cc@161 PS1, Line 161: MiniKdc kdc; Can you abstract this shared setup into the test class? It may require fiddling with TestMiniSentryLifecycle to enable kerberos for it (make it a TEST_P), but that's fine. -- To view, visit http://gerrit.cloudera.org:8080/11657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34695cd4cc6723b70617164d58f8681cefd09ddd Gerrit-Change-Number: 11657 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 12 Oct 2018 17:17:39 +0000 Gerrit-HasComments: Yes
