Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 )
Change subject: [tools] Add locate row tool ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11666/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11666/6//COMMIT_MSG@12 PS6, Line 12: CSV > didn't look at the patch, but from a glance at the commit message: did you The downside of JSON is that it is verbose and cumbersome to type in the command line without making a mistake. Maybe the right path is to have the default be CSV, because it's easy to use, but also accept JSON via a flag to handle cases when the primary key has values that are difficult to enter with CSV. -- To view, visit http://gerrit.cloudera.org:8080/11666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcdcf10bfe6b9df686e86b7134e8634fc0efaac3 Gerrit-Change-Number: 11666 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 12 Oct 2018 18:49:57 +0000 Gerrit-HasComments: Yes
