Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11666 )
Change subject: [tools] Add locate row tool ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/11666/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11666/10//COMMIT_MSG@29 PS10, Line 29: , nit: I think it's supposed to be a column (':') instead of comma (','). http://gerrit.cloudera.org:8080/#/c/11666/10/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11666/10/src/kudu/tools/kudu-admin-test.cc@1513 PS10, Line 1513: String instead of int Just curious: what is the output for '0x10'? http://gerrit.cloudera.org:8080/#/c/11666/10/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/11666/10/src/kudu/tools/tool_action_table.cc@226 PS10, Line 226: ExtractInt64 I'm not sure this works for small negative numbers due to the funkiness of jsonreader wrapper (i.e. if the number fits into int16_t). Did you try negative keys like '-1' with your new tool? I'm curious how it works in that case. http://gerrit.cloudera.org:8080/#/c/11666/10/src/kudu/tools/tool_action_table.cc@351 PS10, Line 351: be nit: 'be' --> 'will be'? -- To view, visit http://gerrit.cloudera.org:8080/11666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcdcf10bfe6b9df686e86b7134e8634fc0efaac3 Gerrit-Change-Number: 11666 Gerrit-PatchSet: 10 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 15 Oct 2018 04:39:58 +0000 Gerrit-HasComments: Yes
