Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11683 )
Change subject: Fix jsonreader signed int extraction and add unsigned extraction ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11683/1/src/kudu/util/jsonreader-test.cc File src/kudu/util/jsonreader-test.cc: http://gerrit.cloudera.org:8080/#/c/11683/1/src/kudu/util/jsonreader-test.cc@135 PS1, Line 135: doc Does it make sense to add test cases where minimum signed value is about to be extracted by various wrapper functions? http://gerrit.cloudera.org:8080/#/c/11683/1/src/kudu/util/jsonreader-test.cc@144 PS1, Line 144: negative nit here and below: would it make sense to use string literal constants for those fields instead? -- To view, visit http://gerrit.cloudera.org:8080/11683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b07757bacc756643aea5613b3491a34cb051a43 Gerrit-Change-Number: 11683 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 15 Oct 2018 17:43:35 +0000 Gerrit-HasComments: Yes
