Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11662 )
Change subject: [rebalancer] location-aware rebalancer (part 2/3) ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11662/1/src/kudu/tools/rebalancer.cc File src/kudu/tools/rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/11662/1/src/kudu/tools/rebalancer.cc@1268 PS1, Line 1268: bool Rebalancer::PolicyFixer::ScheduleNextMove(bool* has_errors, > warning: both sides of overloaded operator are equivalent [misc-redundant-e Done http://gerrit.cloudera.org:8080/#/c/11662/3/src/kudu/tools/rebalancer.cc File src/kudu/tools/rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/11662/3/src/kudu/tools/rebalancer.cc@104 PS3, Line 104: Rebalancer::Rebalancer(const Config& config) > warning: pass by value and use std::move [modernize-pass-by-value] I'm going to ignore this suggestion from tidy for a while. -- To view, visit http://gerrit.cloudera.org:8080/11662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b0ccb3067a42f112e117b31f22d510f96e5234 Gerrit-Change-Number: 11662 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 15 Oct 2018 21:40:22 +0000 Gerrit-HasComments: Yes
