Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 )
Change subject: HMS integration: provide Java API to override owner during table create ...................................................................... Patch Set 8: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/11413/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11413/8//COMMIT_MSG@9 PS8, Line 9: This is necessary so that Impala can override the table owner, instead : of using the inferred username of the connection (which would be : 'impala'). This API is marked as unstable since it's not clear we will : want to support it long term, and there are some open questions about : the fine-grained privileges required to use it. Fleshing this out for my own understanding: today, without the HMS integration, Impala-user 'bob' will create a table, and Impala will, in some order, update the HMS to have a table entry owned by 'bob', and send a create table request to Kudu as user 'impala'. And this mirrors that? http://gerrit.cloudera.org:8080/#/c/11413/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java: http://gerrit.cloudera.org:8080/#/c/11413/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@64 PS8, Line 64: null, false nit: add /*varNames=*/ http://gerrit.cloudera.org:8080/#/c/11413/8/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/11413/8/src/kudu/master/master.proto@424 PS8, Line 424: as nit: with -- To view, visit http://gerrit.cloudera.org:8080/11413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21069d81a4b54e55c399933b69789bf83bd58de0 Gerrit-Change-Number: 11413 Gerrit-PatchSet: 8 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 17 Oct 2018 17:58:33 +0000 Gerrit-HasComments: Yes
