Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11712 )
Change subject: sentry module: introduce using declarations for generated types ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11712/1/src/kudu/sentry/thrift_operators-test.cc File src/kudu/sentry/thrift_operators-test.cc: http://gerrit.cloudera.org:8080/#/c/11712/1/src/kudu/sentry/thrift_operators-test.cc@31 PS1, Line 31: I get that you probably changed this from kudu::sentry:: to sentry:: because that's a more terse way to avoid fully qualifying the types below, but it also means we're defining symbols outside the kudu namespace, which we normally only do when absolutely necessary (i.e. when we need to actually insert something into a different namespace). Would you mind keeping the kudu::sentry:: namespace and add a smattering of using statements instead? -- To view, visit http://gerrit.cloudera.org:8080/11712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51f61eedc1069d362fa1ce26ce0449cce8f0846b Gerrit-Change-Number: 11712 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 17 Oct 2018 20:29:30 +0000 Gerrit-HasComments: Yes
