Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11646 )
Change subject: client: add timeout duration and scan attempts to scanner errors ...................................................................... client: add timeout duration and scan attempts to scanner errors Previously, scanner errors could be confusing because certain types of errors, like ServiceUnavailable, are retriable, and the RPC timeouts mentioned in some error messages tend to be confusingly short because after several retries the client-side deadline is looming. This patch adds additional details to scanner timeout error messages, including information about number of retries and the client-set timeout value. An example of a new "enhanced" error message looks something like this (from the new test that injects an error on scan): Timed out: exceeded configured scan timeout of 1.000s: after 7 scan attempts: unable to retry before timeout: Remote error: Service unavailable: Injecting service unavailable status on Scan due to --scanner_inject_service_unavailable_on_continue_scan Change-Id: I3a8f731f029132d0894355098d5804840f09e7c2 Reviewed-on: http://gerrit.cloudera.org:8080/11646 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Mike Percy <[email protected]> --- M src/kudu/client/client-test.cc M src/kudu/client/scanner-internal.cc M src/kudu/client/scanner-internal.h M src/kudu/tserver/tablet_service.cc 4 files changed, 53 insertions(+), 8 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Mike Percy: Verified -- To view, visit http://gerrit.cloudera.org:8080/11646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3a8f731f029132d0894355098d5804840f09e7c2 Gerrit-Change-Number: 11646 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
