Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 )
Change subject: wip: [sentry] add SentryAuthzProvider ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider-test.cc File src/kudu/sentry/sentry_authz_provider-test.cc: http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider-test.cc@27 PS1, Line 27: #include "kudu/sentry/mini_sentry.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider-test.cc@36 PS1, Line 36: using ::sentry::TAlterSentryRoleAddGroupsRequest; > warning: using decl 'SaslProtection' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider.h File src/kudu/sentry/sentry_authz_provider.h: http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider.h@32 PS1, Line 32: > update doc Done http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider.h@51 PS1, Line 51: > warning: function 'kudu::sentry::SentryAuthzProvider::AuthorizeCreateTable' Done http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider.cc File src/kudu/sentry/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider.cc@31 PS1, Line 31: using sentry::TListSentryPrivilegesRequest; > warning: using decl 'optional' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider.cc@60 PS1, Line 60: > Sentry Done http://gerrit.cloudera.org:8080/#/c/11659/1/src/kudu/sentry/sentry_authz_provider.cc@119 PS1, Line 119: } > warning: loop variable is copied but only used as const reference; consider Done -- To view, visit http://gerrit.cloudera.org:8080/11659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I254828d640cd905e33dbaf0fe100d660bc9e6772 Gerrit-Change-Number: 11659 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Oct 2018 06:41:48 +0000 Gerrit-HasComments: Yes
