Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11724 )
Change subject: [tools] updated comments on 'kudu perf loadgen' ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11724/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11724/1//COMMIT_MSG@12 PS1, Line 12: masters' RPC end-point argument misplaced. > Isn't it legal to place positional parameters either before or after gflags I remember it was not working for me when masters addresses came the last in the list of arguments, but when try it now it works. I'm not sure what that was, most likely a PEBKAC case. Anyway, after the update the examples look more uniform. I would like to keep it that way if you don't mind. http://gerrit.cloudera.org:8080/#/c/11724/1/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/11724/1/src/kudu/tools/tool_action_perf.cc@24 PS1, Line 24: As an option, it's possible to run a > Nit: "Optionally, a post-insertion scan may be run on the table..." Done http://gerrit.cloudera.org:8080/#/c/11724/1/src/kudu/tools/tool_action_perf.cc@24 PS1, Line 24: structure > Maybe also add how the table is normally deleted when the tool finishes, bu Done http://gerrit.cloudera.org:8080/#/c/11724/1/src/kudu/tools/tool_action_perf.cc@260 PS1, Line 260: neither existing tables " : "nor their data are ever dropped/deleted." > Nit: should be singular, not plural. "Neither the existing table nor its da Done -- To view, visit http://gerrit.cloudera.org:8080/11724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If171957db9d9be8d14b5031a64f4edbfa5470be0 Gerrit-Change-Number: 11724 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Oct 2018 20:02:59 +0000 Gerrit-HasComments: Yes
