Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11726
to review the following change.
Change subject: thread: show ulimit nproc when thread creation fails
......................................................................
thread: show ulimit nproc when thread creation fails
It seems useful to return the ulimit nproc when thread creation fails to
help an administrator or dev diagnose the cause of the fork failure.
This patch adds that info to the error Status returned from
Thread::Create().
Tested manually on Linux. Example:
mpercy@mpercy-T460p:~/src/kudu/build/dynclang$ ps -efwwwL | grep mpercy | wc -l
2382
mpercy@mpercy-T460p:~/src/kudu/build/dynclang$ ulimit -u 2390
mpercy@mpercy-T460p:~/src/kudu/build/dynclang$ ./bin/kudu-tserver --fs-wal-dir
$(pwd)/wal --logtostderr
I1018 13:23:53.856669 23095 tablet_server_main.cc:78] Tablet server non-default
flags:
--fs_wal_dir=/home/mpercy/src/kudu/build/dynclang/wal
--heap_profile_path=/tmp/kudu-tserver.23095
--logtostderr=true
Tablet server version:
kudu 1.9.0-SNAPSHOT
revision 53e02879885ef2e1598549b5655f610f12810011-dirty
build type DEBUG
built by mpercy at 18 Oct 2018 13:11:31 PST on mpercy-T460p
I1018 13:23:53.857304 23095 minidump.cc:237] Setting minidump size limit to 20M
F1018 13:23:53.857630 23095 kernel_stack_watchdog.cc:75] Check failed: _s.ok()
Bad status: Runtime error: Could not create thread (max number of processes for
current user is 2390): Resource temporarily unavailable (error 11)
*** Check failure stack trace: ***
Wrote minidump to
/tmp/minidumps/kudu-tserver/5024088d-65f7-4159-e5fd33a8-1d89aa95.dmp
Wrote minidump to
/tmp/minidumps/kudu-tserver/5024088d-65f7-4159-e5fd33a8-1d89aa95.dmp
*** Aborted at 1539894233 (unix time) try "date -d @1539894233" if you are
using GNU date ***
PC: @ 0x7f864d7f7e97 gsignal
*** SIGABRT (@0x3e800005a37) received by PID 23095 (TID 0x7f864cd52900) from
PID 23095; stack trace: ***
@ 0x7f8652273890 (unknown)
@ 0x7f864d7f7e97 gsignal
@ 0x7f864d7f9801 abort
@ 0x7f865006a2d9 kudu::AbortFailureFunction()
@ 0x7f864f463d0d google::LogMessage::Fail()
@ 0x7f864f465ce4 google::LogMessage::SendToLog()
@ 0x7f864f46382d google::LogMessage::Flush()
@ 0x7f864f4666b9 google::LogMessageFatal::~LogMessageFatal()
@ 0x7f865002b304 kudu::KernelStackWatchdog::KernelStackWatchdog()
@ 0x7f865002e70a Singleton<>::CreateInstance()
@ 0x7f865002e6c9 Singleton<>::Init()
@ 0x7f864f6ef92c GoogleOnceInternalInit()
@ 0x7f86557206ed GoogleOnceInit()
@ 0x7f865002e6a7 Singleton<>::get()
@ 0x7f865002d1d9 kudu::KernelStackWatchdog::GetInstance()
@ 0x7f865002c813 kudu::KernelStackWatchdog::CreateAndRegisterTLS()
@ 0x7f8654ab35d6 kudu::KernelStackWatchdog::GetTLS()
@ 0x7f8654aaf4dc kudu::ScopedWatchKernelStack::ScopedWatchKernelStack()
@ 0x7f86500bc624 kudu::Thread::StartThread()
@ 0x7f865006bafd kudu::Thread::Create<>()
@ 0x7f865006a75b
kudu::MinidumpExceptionHandler::StartUserSignalHandlerThread()
@ 0x7f865006a5ad
kudu::MinidumpExceptionHandler::RegisterMinidumpExceptionHandler()
@ 0x7f865006b0b2
kudu::MinidumpExceptionHandler::MinidumpExceptionHandler()
@ 0x7f86554d88bb kudu::server::ServerBase::ServerBase()
@ 0x7f8655a20a3c kudu::kserver::KuduServer::KuduServer()
@ 0x7f865571ccf3 kudu::tserver::TabletServer::TabletServer()
@ 0x4064a2 kudu::tserver::TabletServerMain()
@ 0x4060a2 main
@ 0x7f864d7dab97 __libc_start_main
@ 0x405fba _start
Aborted (core dumped)
Change-Id: I8e0bd0d0776142e8feff18bffe15e61ca1ba5816
---
M src/kudu/util/thread.cc
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/11726/1
--
To view, visit http://gerrit.cloudera.org:8080/11726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e0bd0d0776142e8feff18bffe15e61ca1ba5816
Gerrit-Change-Number: 11726
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
