Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11733 )
Change subject: Add missing test dependency for Hive tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11733/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11733/1//COMMIT_MSG@11 PS1, Line 11: Notably CDH 6.1-SNAPSHOT Maybe avoid calling out specific CDH versions? http://gerrit.cloudera.org:8080/#/c/11733/1/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/11733/1/java/kudu-client/build.gradle@41 PS1, Line 41: // The HMS client relies on the MR client-core artifact for JobConf, but : // gradle doesn't correctly track the dependency for some versions of the HMS : // jar. Rather, the HMS is sometimes lists MR client-core as an optional dependency, but our tests definitely depend on it, so we're doing it explicitly here so gradle can pick it up. -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 00:47:28 +0000 Gerrit-HasComments: Yes
