Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11728 )
Change subject: Add ExtractDouble method to JsonReader and small improvements ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11728/1/src/kudu/util/jsonreader-test.cc File src/kudu/util/jsonreader-test.cc: http://gerrit.cloudera.org:8080/#/c/11728/1/src/kudu/util/jsonreader-test.cc@113 PS1, Line 113: ASSERT_TRUE(r.ExtractInt32(r.root(), "big", nullptr).IsInvalidArgument()); > What about trying to extract int64max using ExtractDouble()? Should it be I added tests for the large 64-bit integers. I think adding a whole test for extracting ints using ExtractDouble is way overkill...it's testing the library, not our code. -- To view, visit http://gerrit.cloudera.org:8080/11728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iccbdc2467746b68ac871f5feeb01e610610b13d6 Gerrit-Change-Number: 11728 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 19 Oct 2018 16:39:55 +0000 Gerrit-HasComments: Yes
