Will Berkeley has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11729 )

Change subject: [tools] Add locate_row support for unsupported key column types
......................................................................

[tools] Add locate_row support for unsupported key column types

BOOL, FLOAT, and DOUBLE are not supported as types for key columns. But
there's actually no reason why the tool can't pre-emptively support them
in case they are ever permitted as key column types.

There's no additional tests because it's not possible to create a table
with these types in the primary key.

Change-Id: Id1ba6de90feef4c2c565d9033ff442b723a51d7b
Reviewed-on: http://gerrit.cloudera.org:8080/11729
Tested-by: Will Berkeley <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
---
M src/kudu/tools/tool_action_table.cc
1 file changed, 32 insertions(+), 0 deletions(-)

Approvals:
  Will Berkeley: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/11729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1ba6de90feef4c2c565d9033ff442b723a51d7b
Gerrit-Change-Number: 11729
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>

Reply via email to