Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11657 )
Change subject: [sentry] Fill out more sentry client API ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11657/5/src/kudu/sentry/sentry_client-test.cc File src/kudu/sentry/sentry_client-test.cc: http://gerrit.cloudera.org:8080/#/c/11657/5/src/kudu/sentry/sentry_client-test.cc@211 PS5, Line 211: // Similar to above test to verify that the client can communicate with the : // Sentry service to grant roles, and errors are converted to Status : // instances. > Is 'grant' the right verb to use here though? I would think one "adds" or " Yeah, to avoid confusing, I changed the name to 'TestAlterRoleAddGroups' in https://gerrit.cloudera.org/#/c/11659/3/src/kudu/sentry/sentry_client-test.cc@226 -- To view, visit http://gerrit.cloudera.org:8080/11657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34695cd4cc6723b70617164d58f8681cefd09ddd Gerrit-Change-Number: 11657 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 22 Oct 2018 20:55:12 +0000 Gerrit-HasComments: Yes
