Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11765 )
Change subject: transaction_tracker: add more information to the out-of-memory message ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc@116 PS2, Line 116: was $2 and the current consumption is $3 The issue is that (current consumption) + (tx consumption) > (mem tracket limit), so the tx is rejected, if I'm understanding it right. Maybe the message should be: Substitute("transaction rejected due to memory pressure: the memory usage of this transaction ($0) plus the current consumption ($1) exceeds the transaction memory limit ($2) or the limit of an ancestral tracker", driver_mem_foorprint, mem_tracker_->consumption(), mem_tracker_->limit()); http://gerrit.cloudera.org:8080/#/c/11765/2/src/kudu/tablet/transactions/transaction_tracker.cc@115 PS2, Line 115: transaction " : "consumption' transaction's consumption -- To view, visit http://gerrit.cloudera.org:8080/11765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4017c1aecec29cd4b4b04c15efa4bf38c925cb9 Gerrit-Change-Number: 11765 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 24 Oct 2018 18:07:42 +0000 Gerrit-HasComments: Yes
