Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11801 )
Change subject: Improve consensus queue overflow logging ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11801/1/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: http://gerrit.cloudera.org:8080/#/c/11801/1/src/kudu/consensus/consensus_peers.cc@458 PS1, Line 458: .$2 How is it going to look like and why is it separated by a dot from the tablet id? http://gerrit.cloudera.org:8080/#/c/11801/1/src/kudu/consensus/consensus_peers.cc@461 PS1, Line 461: tablet_id_ The LOG_WITH_PREFIX_UNLOCKED() produces a string prefix that already contains information on tablet identifier. Is it really necessary to duplicate it in the message itself? -- To view, visit http://gerrit.cloudera.org:8080/11801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7697c63babefac0f76bcc8c87d70f7e7125e55cc Gerrit-Change-Number: 11801 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 26 Oct 2018 18:50:34 +0000 Gerrit-HasComments: Yes
