Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11797 )
Change subject: WIP:[sentry] Integrate AuthzProvider into CatalogManager ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11797/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/11797/1/src/kudu/master/catalog_manager.cc@257 PS1, Line 257: DEFINE_string(trusted_user_acl, "", > spitballing: in order to keep as much of the authz behavior in an easily au +1, I think it makes sense to put this in authz_provider.cc, and maybe keep a `const std::unordered_set` of the users as a member of the AuthzProviders. Then we'd be able to do a `ContainsKey()` on this instead of `std::find()` to check membership of this list. http://gerrit.cloudera.org:8080/#/c/11797/1/src/kudu/sentry/sentry_policy_service.thrift File src/kudu/sentry/sentry_policy_service.thrift: http://gerrit.cloudera.org:8080/#/c/11797/1/src/kudu/sentry/sentry_policy_service.thrift@26 PS1, Line 26: # - Rename enum TSentryGrantOption.TRUE and TSentryGrantOption.FALSE to avoid : # conflict What's the significance of this change? What is the conflict? -- To view, visit http://gerrit.cloudera.org:8080/11797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4aa027ae6eb4520db48ce348db552c9feec2a8 Gerrit-Change-Number: 11797 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 28 Oct 2018 05:08:42 +0000 Gerrit-HasComments: Yes
